Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: cope with missing Standard 14 fonts in fields #2677

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

pubpub-zz
Copy link
Collaborator

closes #2670

in alternative to #2671

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (44d08ae) to head (5dda438).
Report is 56 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2677   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          51       51           
  Lines        8538     8538           
  Branches     1702     1702           
=======================================
  Hits         8123     8123           
  Misses        261      261           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

@BrooksWatson717 / @stefan6419846

Your opinion ?

@stefan6419846
Copy link
Collaborator

Compared to #2671, how does this behave if the font is missing? #2671 would add the font entry, this PR just skips the logic conditionally. Does this have an effect on real-world usage?

@pubpub-zz
Copy link
Collaborator Author

pubpub-zz commented May 27, 2024

Compared to #2671, how does this behave if the font is missing? #2671 would add the font entry, this PR just skips the logic conditionally. Does this have an effect on real-world usage?

Helvetica font is part of the default fonts that may not be defined. Also if you want to declare the font you need the full definition with far much more data than proposed in #2671

Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there has been no further feedback here and on the other PR, I am going to merge this one now.

@stefan6419846 stefan6419846 merged commit 3c9f449 into py-pdf:main Jun 7, 2024
16 checks passed
stefan6419846 added a commit that referenced this pull request Jun 23, 2024
## What's new

### New Features (ENH)
- Accept ETen-B5 and UniCNS-UTF16 encodings (#2721) by @pubpub-zz
- Add decode_as_image() to ContentStreams (#2615) by @pubpub-zz
- context manager for PdfReader (#2666) by @tibor-reiss
- Add capability to set font and size in fields (#2636) by @pubpub-zz
- Allow to pass input file without named argument (#2576) by @pubpub-zz

### Bug Fixes (BUG)
- Fix deprecation for Ressources when using old constants (#2705) by @stefan6419846
- Fix images issue 4 bits encoding and LUT starting with UTF16_BOM (#2675) by @pubpub-zz
- Reading large compressed images takes huge time to process (#2644) by @snanda85
- Highlighted Text Cannot Be Printed (#2604) by @Nifury
- Fix UnboundLocalError on malformed pdf (#2619) by @farjasju

### Documentation (DOC)
- Various improvements on docstrings and examples by @j-t-1

### Robustness (ROB)
- Cope with missing Standard 14 fonts in fields (#2677) by @pubpub-zz
- Improve inline image extraction (#2622) by @pubpub-zz
- Cope with loops in Fields tree (#2656) by @pubpub-zz
- Discard /I in choice fields for compatibility with Acrobat (#2614) by @pubpub-zz
- Cope with some issues in pillow (#2595) by @pubpub-zz
- Cope with some image extraction issues (#2591) by @pubpub-zz

### Maintenance (MAINT)
- Deprecate interiour_color with replacement interior_color (#2706) by @j-t-1
- Add deprecate_with_replacement to PdfWriter.find_bookmark (#2674) by @j-t-1

### Code Style (STY)
- Change Link to be a non-markup annotation (#2714) by @j-t-1

[Full Changelog](4.2.0...4.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Fill PDFs without /DR dictionary
2 participants